-
Notifications
You must be signed in to change notification settings - Fork 326
Simplify local builds with Docker Compose, Also updated README #841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This makes it so docker does not create these directories with root
I still need to update the readme but could some of you check this out? I am using docker and docker-compose to make it easier for current developers to stay in sync and also make it easier for new contributions. Scala developers probably don't want to deal with the specifics of ruby, rbenv, rvm, bundle, jekyll, etc. They are probably familiar with html, markdown, docker, and docker-compose. The commands to run are in the bin directory but should all be run from the root directory. ie. The first time you run Also checkout: If this PR gets any traction or feedback I will polish it up and start working on the readme. :-) @heathermiller @SethTisue @ashawley @OlivierBlanvillain @Philippus |
Is anyone interested in trying this out? If not than I can close the PR. I am hoping this will help get more contributers into the project. |
@jarrodu , FWIW I had not known of this project until 30 minutes ago, and got this up and running, and made a change in under 10 mins: |
That is so cool! Thanks so much for sharing. |
I tried it, and it works! I had to install If you would like to finish polishing up the PR, I'll be happy to merge it unless anyone else objects? I trust that everything you've included here is complementary to the existing process for updating the website. In the unlikely event that it does, make sure it's documented as anyone with an existing process which works for them would certainly need to know! :) |
Thanks for the positive encouragement. I will go through everything in detail tomorrow. Today I am getting a cat! I will also review and update the README. As far as I can tell this should not change the build process for people that are already comfortable with their setups. It will also not change the Travis build. We will see how well people like this and maybe in the future I can expand the scope a bit. |
I haven't had the chance to try this yet, but it certainly looks like an appealing option to offer. |
README.md
Outdated
|
||
## Permalinks | ||
### Permalinks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does anyone know how to fix this rendering issue? It is also present on the master branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the character between '##' and 'Permalinks' is not a space.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup. That fixed it. :-)
I'm sure they are interdependent, but it seems like there are at least 3 changes under consideration here:
In the interest of getting this important work integrated rather than delayed, would it be possible to make the changes separately? I think I have an old version of docker-compose, so it didn't work for me. I'll need to look in to upgrading.
|
I minimized the differences between master's and docker-compose's version of Gemfile.lock. This should make reviewing easier. Since my goal here is to make it easier and more inviting for new contributors I prefer to keep the rest of the changes in this PR. The existing contributors can continue using the workflows they are used to. I am running Compose 1.8 which is the default if you are running Ubuntu 17.10. Version 1.19 installed using pip also works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great because I've struggled so much to get this repo working on my local machine, that I had to install vagrant and use my own environment. Thanks for the work @jarrodu 😄
Thanks, @jarrodu. That will make it easier to review.
I'm all for this. I tried to do a small piece of that in #693, which I suspect is one of the technical hurdles that motivates using docker actually. |
|
||
In this new version of the scala-lang site we've tried to follow a `pretty permalink` style, so that any generated page will have an permalink finishing in a slash character (`/`). This will tell Jekyll to build that particular page as an `index.html` inside a folder with a name as specified in the provided permalink. i.e.: if a page has a permalink as follows: | ||
We trie to follow a [pretty permalink](https://jekyllrb.com/docs/permalinks/) style, so that any generated page will have a link finishing in a slash character (`/`). This will tell Jekyll to build that particular page as an `index.html` inside a folder with a name as specified in the provided permalink. i.e.: if a page has a permalink as follows: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We try
Thank you again, @jarrodu! Happy to have this contribution. :) |
Feel free to look around if you like. I will get back to this tonight or tomorrow. :-)
The main things I still need to do is to provide a reason for the change and update the readme with how to use it.