Skip to content

Feature/scastie front page #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2017
Merged

Conversation

MasseGuillaume
Copy link
Contributor

@MasseGuillaume MasseGuillaume commented Jul 17, 2017

fix #697

@MasseGuillaume MasseGuillaume force-pushed the feature/scastie-front-page branch from 4cd92ca to 9394ba9 Compare July 17, 2017 13:45
@MasseGuillaume MasseGuillaume force-pushed the feature/scastie-front-page branch from 9394ba9 to 9f56cd7 Compare July 17, 2017 13:46

function run(){
console.log("run");
// var scastieBaseUrl = "https://scastie.scala-lang.org";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm redeploying scastie, I will force push with the url pointing on the prod server.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, cool. Let me know when it's up, we can test to make sure it's all good, and then we fix this.

@MasseGuillaume
Copy link
Contributor Author

@heathermiller This PR is good to go.
out

@heathermiller
Copy link
Member

❤️

@heathermiller heathermiller merged commit b4b0bce into master Jul 18, 2017
Copy link
Member

@heathermiller heathermiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems not to be working. Clicking the button isn't doing anything

</section>m
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Broken

heathermiller added a commit that referenced this pull request Jul 18, 2017
heathermiller added a commit that referenced this pull request Jul 18, 2017
@heathermiller
Copy link
Member

All good now

@MasseGuillaume MasseGuillaume deleted the feature/scastie-front-page branch July 18, 2017 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants