Skip to content

Scaladex autocomplete #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

MasseGuillaume
Copy link
Contributor

auto

@MasseGuillaume
Copy link
Contributor Author

MasseGuillaume commented Jul 13, 2017

when we find the missing sass this is the style:

.autocomplete-suggestions {
    width: 100%;
    background: #fff;
    top: 42px;
    left: 0;
    position: absolute;
    z-index: 9999;
    -webkit-box-shadow: 0 2px 20px rgba(0, 0, 0, 0.2);
    box-shadow: 0 2px 20px rgba(0, 0, 0, 0.2);
}

.autocomplete-suggestions {
    padding: 0;
    margin: 0;
}

.autocomplete-suggestions .autocomplete-suggestion {
    padding: 15px;
    list-style: none;
    border-bottom: 1px solid rgba(0, 43, 55, 0.1);
}

.autocomplete-suggestions .autocomplete-suggestion:last-child {
    border-bottom: none;
}

.autocomplete-suggestions .autocomplete-suggestion a {
    color: #586e75;
}

.autocomplete-suggestions .autocomplete-suggestion a:hover,
.autocomplete-suggestions .autocomplete-suggestion a:active,
.autocomplete-suggestions .autocomplete-suggestion a:focus {
    text-decoration: none;
}

.autocomplete-suggestions .autocomplete-suggestion a p {
    color: #224951;
    margin: 0;
    font-weight: 400;
}

.autocomplete-suggestions .autocomplete-suggestion:hover,
.autocomplete-suggestions .autocomplete-suggestion.selected {
    background: #edf1f1;
    cursor: default;
}

@heathermiller
Copy link
Member

Could you explain what you did with style.css?

@heathermiller
Copy link
Member

Ok, so this actually shouldn't be merged with the changes to style.css I take it.

@heathermiller
Copy link
Member

#685

@MasseGuillaume MasseGuillaume force-pushed the feature/scaladex-autocomplete branch 2 times, most recently from 9efecd1 to f531632 Compare July 13, 2017 18:55
@MasseGuillaume
Copy link
Contributor Author

@heathermiller rebased, this is good to go.

@heathermiller
Copy link
Member

Thanks, but this is still not working.

For example, type in cats. Nothing is found in the dropdown. That's OK, we can just go to Scaladex, right? Wrong. Pressing enter after typing cats does nothing.

So this still needs to be fixed.

@heathermiller heathermiller changed the title Style for scaladex autocomplete WIP: Scaladex autocomplete Jul 14, 2017
@MasseGuillaume MasseGuillaume force-pushed the feature/scaladex-autocomplete branch from f531632 to 2296984 Compare July 17, 2017 09:58
@MasseGuillaume MasseGuillaume changed the title WIP: Scaladex autocomplete Scaladex autocomplete Jul 17, 2017
@MasseGuillaume
Copy link
Contributor Author

@heathermiller good to go.

@MasseGuillaume MasseGuillaume force-pushed the feature/scaladex-autocomplete branch from 2296984 to 3209f17 Compare July 17, 2017 10:07
@MasseGuillaume MasseGuillaume force-pushed the feature/scaladex-autocomplete branch from 3209f17 to e38f276 Compare July 17, 2017 10:29
@heathermiller
Copy link
Member

Perfect! Thank you!

@heathermiller heathermiller merged commit 718844c into scala:master Jul 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants