-
Notifications
You must be signed in to change notification settings - Fork 326
multiple improvements to Community page #323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
444b637
community page: Gitter too, not just IRC
SethTisue b298f67
copyedit/cleanup
SethTisue a8bbf8c
remove obsolete link
SethTisue b6393f9
add new link (Awesome Scala)
SethTisue b0ffc2f
community page: link to code of conduct
SethTisue fc4276c
community page: de-emphasize & reword Gmane thing
SethTisue File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't it be nice though to still include the link to the Scala Meetups and Scala Space website?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Scala Space link remains below in the "User Groups" section — that seemed like enough to me, but I don't have a strong feeling about it one way or the other.
It seems I was a bit eager in removing the scala.meetup.com link — Scala Space is more curated, but now that I take a second look, I see the meetup link casts a wider net and pulls in additional relevant listings like Spark groups. So I added it back in fda1a6b.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great :) Thanks a lot, Seth!