Scala 2.10.4-RC3 #167
Merged
Scala 2.10.4-RC3 #167
+295
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review by @heathermiller or @sjrd I guess. |
|
LGTM. Feel free to merge when you announce. |
|
There are some formatting issues that (I think) have been around for a while – some code snippets are wrapping into the sidebar. But that shouldn't hold it back from being pulled in, am just noting that I or someone else should fix that eventually... So, LGTM! Pull in when you want to announce :) |
|
Thanks guys. Yes, I noticed the formatting glitch but my html-foo is lacking here. I fixed the download page and force pushed my commit. I'll merge without waiting for another reviews. Nothing could have gone wrong with... 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be announced tomorrow.