Skip to content

alt-details does not need javascript #1381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 11, 2022
Merged

alt-details does not need javascript #1381

merged 1 commit into from
May 11, 2022

Conversation

bishabosha
Copy link
Member

using some css tricks to implement the accordion behaviour without JS:
Screenshot 2022-05-11 at 14 22 06

@bishabosha bishabosha requested a review from julienrf May 11, 2022 12:22
julienrf
julienrf approved these changes May 11, 2022
View reviewed changes
Copy link
Contributor

@julienrf julienrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice trick 😉

@bishabosha bishabosha merged commit 715a065 into scala:main May 11, 2022
@bishabosha bishabosha mentioned this pull request May 13, 2022
Merged
@bishabosha bishabosha deleted the no-js-accordion branch July 18, 2022 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrf julienrf julienrf approved these changes

Assignees

@julienrf julienrf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bishabosha @julienrf