Add default HTML-Proofer Typhoeus configuration to the CI command line #1380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently when specifying --typhoeus-config on the command line, all the defaults are discarded, and must be re-specified if desired. The default values were taken from: https://github.com/gjtorikian/html-proofer/blob/1bab3a1a18e95a10378371ddf000df9bea01740e/lib/html-proofer/configuration.rb#L36-L44 This should hopefully fix the rash of 403s since scala#1376 and scala#1378 were merged.
|
The PR run doesn't test this, so let's just merge it and then wait and see what happens with the next cron run. Thanks Tom! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently when specifying
--typhoeus-configon the command line, all the defaults are discarded, and must be re-specified if desired.The default values were taken from:
https://github.com/gjtorikian/html-proofer/blob/1bab3a1a18e95a10378371ddf000df9bea01740e/lib/html-proofer/configuration.rb#L36-L44
This should hopefully fix the rash of 403s since #1376 and #1378 were merged.