Skip to content

Adding an issues Github search link #1299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 23, 2021
Merged

Conversation

BalmungSan
Copy link
Contributor

No description provided.

@SethTisue SethTisue self-requested a review November 11, 2021 19:04
@SethTisue
Copy link
Member

SethTisue commented Nov 14, 2021

I pushed some changes. wdyt?

I think it's better not to offer the combined "good first issue" AND "help wanted" link, because many projects consider any "good first issue" ticket to be implicitly "help wanted" and don't necessarily apply both labels.

Copy link
Contributor Author

@BalmungSan BalmungSan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is funny because I can't approve my own PR.

I like a lot your changes Seth, thanks for giving this a shot :)

@SethTisue SethTisue merged commit 3a6cf29 into scala:main Nov 23, 2021
@BalmungSan BalmungSan deleted the patch-1 branch November 23, 2021 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants