Skip to content

Write blog post about Metals #1034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 17, 2019
Merged

Write blog post about Metals #1034

merged 2 commits into from
Apr 17, 2019

Conversation

olafurpg
Copy link
Contributor

No description provided.

Copy link
Contributor

@gabro gabro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor suggestions, but otherwise 💯

extension on the VS Code Marketplace and open an sbt project directory. The
Metals extension will prompt you to import the build.

![Import sbt build](https://i.imgur.com/0VqZWay.png)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we store the images on our own servers instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kept the external links since I wanted to avoid bloating the git repository with GIFs. I can download and embed the images, wdyt @SethTisue ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong opinion either way. We don't publish that many blog posts, so it's probably okay.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kept the external URLs. In general, I prefer external links because it makes the markdown source more portable. With local image links you can't as easily share the markdown source.

@olafurpg
Copy link
Contributor Author

Thank you for the review!

@SethTisue
Copy link
Member

LGTM as is, but also, you might consider adding some text about what work remains to do. Like, why is this 0.5 and not 1.0. Is there any reason I wouldn't choose Metals.

@olafurpg
Copy link
Contributor Author

@SethTisue good point! I added a section on "Future work" listing limitations (no refactoring/debugging/...) and recommended to use IntelliJ instead for those use-cases.

@olafurpg olafurpg merged commit 4c7c629 into scala:master Apr 17, 2019
@olafurpg olafurpg deleted the metals branch April 17, 2019 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants