Skip to content

Bump to new snapshot version #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2016
Merged

Conversation

retronym
Copy link
Member

No description provided.

@retronym retronym self-assigned this Oct 29, 2016
@retronym
Copy link
Member Author

retronym commented Oct 29, 2016

@adriaanm @Ichoran @szeiger I think we're at a point were we should publish 1.0.0 of this module and commit to backwards binary compatibility, which would help upstream projects. WDYT? It would be advantageous to do this relatively soon as upstream libraries will be releasing for 2.12.0 soon.

@Ichoran
Copy link
Contributor

Ichoran commented Oct 29, 2016

I recommend running something like the collections-laws tests on the library before considering it 1.0. I wrote so much new code that wasn't very heavily tested (everything had basic tests, at least) that I am sure there are bugs in there waiting to be found. I don't need to be the one to run these tests, but it would be good if someone did. I am giving an important talk on Nov. 4, after which I could do it.

In particular, with iterators, it's important to test all the variant ways that an underlying collection can be sized--e.g. all the different sizes of immutable maps that actually have distinct implementations--and if there are any cases where you're modifying and wrapping (e.g. flatMap, collect, etc.), to test the functionality on both plain and modified/wrapped cases.

@retronym
Copy link
Member Author

retronym commented Nov 9, 2016

Okay, I'll keep this pre-1.0 for now.

@retronym retronym closed this Nov 9, 2016
@retronym retronym reopened this Nov 9, 2016
@retronym retronym merged commit 4453cad into scala:master Nov 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants