Improvements to Java 8 Stream support #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both `charStepper` and `codepointStepper` are available through separate methods. The default `stepper` methods from `MakesIntStepper` is equivalent to `charStepper`.
This avoids the duplication of `seqStream` etc. method for collections that also support parallel streams.
|
LGTM. I didn't check every single site of modification, but the major cleanups (separating parStream and seqStream and flattening the chain of low priority traits, and changing the parameterization of MakesStepper) look really good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a collection of changes from the discussion on #61 which I expect to be straight-forward. Compared to my earlier branch, I removed the commit that added the
T <: AnyRefrestriction toStreamConverters. This needs a better design to take widening conversions into account.Review by @Ichoran