add a Travis build #165
Merged
add a Travis build #165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SethTisue
force-pushed
the
travis
branch
2 times, most recently
from
5f3eced to
7735726
Compare
SethTisue
force-pushed
the
travis
branch
4 times, most recently
from
d4ced67 to
8348a81
Compare
maybe this tests a smidgen more
|
review by @adriaanm |
|
LGTM -- nice! |
|
I just noticed that I had already done the Typesafe->Lightbend changes on the 2.11.x branch and they just hadn't been merged to 2.12.x. But 2.11.x has an sbt-native-packager downgrade we don't want (we hope!) on 2.12.x. So I think we can just consider the two branches to have diverged, now. We expect 2.11.9 to be the last 2.11.x release anyway; any real action will be on 2.12.x from now on. |
|
SGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and also upgrade to sbt 0.13.13 while we're at it
and Lightbend some Typesafes