Skip to content

Fix SI-9202: fix punctuation in MSI installer #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2015
Merged

Fix SI-9202: fix punctuation in MSI installer #147

merged 1 commit into from
Mar 30, 2015

Conversation

adriaanm
Copy link
Contributor

@adriaanm adriaanm commented Mar 6, 2015

No description provided.

@jsuereth
Copy link
Contributor

LGTM.

Warnings:

  1. You should remove "the" so the lame sort algorithm doesn't put it in the "T" section
  2. This may mean the detection of whether or not the new version is the same as the old one is broken on windows. We may not care enough to not fix this.

@adriaanm
Copy link
Contributor Author

Thanks, fixed. Punted on (2).

adriaanm added a commit that referenced this pull request Mar 30, 2015
@adriaanm
Merge pull request #147 from scala/t9202
84b3d8e 
SI-9202 fix punctuation, sorting in MSI installer
@adriaanm adriaanm merged commit 84b3d8e into 2.11.x Mar 30, 2015
@SethTisue SethTisue added this to the 2.11.7 milestone Jun 19, 2015
@scabug scabug mentioned this pull request Apr 7, 2017
Closed
@dwijnand dwijnand deleted the t9202 branch October 21, 2020 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.11.7
Development

Successfully merging this pull request may close these issues.
3 participants
@adriaanm @jsuereth @SethTisue