Skip to content

fix errors in bug #135 and fix bug #66 #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2014
Merged

Conversation

bkanuka
Copy link
Contributor

@bkanuka bkanuka commented Oct 14, 2014

I chose scala-internals@googlegroups.com as the maintainer email address. Correct me if wrong.

@bkanuka bkanuka mentioned this pull request Oct 14, 2014
@adriaanm
Copy link
Contributor

adriaanm commented Dec 5, 2014

Thank you, sorry this PR went unnoticed so long! I'm okay bumping our debian dependency to openjdk7, even though we don't technically require it. EDIT: Hmm, thinking about it, we should probably not change this mid-cycle. We're going to require 8 in 2.12 anyway, so let's defer the version bump until then.

@bkanuka
Copy link
Contributor Author

bkanuka commented Dec 5, 2014

java-runtime-headless is a kind of "catch-all" virtual package for Java in Debian. It basically means "you have java installed". In wheezy it is provided by openjdk6 and openjdk7 (so as long as either is installed, the dependency is satisfied), in sid, openjdk8 will also satisfy the requirement of java-runtime-headless. The benefit of using java-runtime-headless is that this dep can be satisfied by packages outside the default Debian repos. For example, if a user had a recent Oracle Java installed, they would still be able to install from this deb.

I know it looks this way, but my attempt was not to bump the version, but to follow packaging best-practices.

@adriaanm
Copy link
Contributor

adriaanm commented Dec 5, 2014

Oh right, sorry I didn't notice there was an OR between openjdk-7-jre-headless and java-runtime-headless

@adriaanm
Copy link
Contributor

adriaanm commented Dec 5, 2014

Thanks, @bkanuka!

adriaanm added a commit that referenced this pull request Dec 5, 2014
fix errors in bug #135 and fix bug #66
@adriaanm adriaanm merged commit 92aea89 into scala:master Dec 5, 2014
@bkanuka bkanuka deleted the bug-#135 branch December 8, 2014 16:33
@bkanuka
Copy link
Contributor Author

bkanuka commented Jun 6, 2015

Yup, okay you're totally right. But I think @adriaanm was implying in his first comment that I shouldn't bump up to Java 7. So I will change the depend to java6-runtime-headless

@adriaanm
Copy link
Contributor

adriaanm commented Jun 9, 2015

Sounds good, thanks! Users should be able to install current Scala on Java 6. Scala 2.12 will require Java 8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants