Test failures on JDK 22 (on both 2.12.x and 2.13.x)

[SethTisue]

seen at e.g. https://github.com/scala/scala/actions/runs/8636734847/job/23677330475

[error] 3 of 20 test tasks failed:
[error] - junit/testOnly -- +v
[error]   - junit/test:testOnly failed: sbt.TestsFailedException: Tests unsuccessful
[error] - partest run
[error]   - test/it:testOnly failed: sbt.TestsFailedException: Tests unsuccessful
[error] - partest pos neg jvm
[error]   - test/it:testOnly failed: sbt.TestsFailedException: Tests unsuccessful

I re-reran it a few times to be sure they aren't spurious.

example 2.13 job: https://github.com/scala/scala/actions/runs/8636734847/job/23677330475

one weird thing is that the Ubuntu jobs fail but the Windows jobs are green, wtf?

[som-snytt]

Scala interpreter should evaluate arithmetic expression failed is not promising.

On a dark background it looks positively diabolical.

Oh, I see we were supposed to zap the invader before it reached the bottom.

[som-snytt]

the ReplTest output is in color. That's run/StringConcat. Also, partest tab complete doesn't match case-correcting like zsh.

[SethTisue]

Scala interpreter should evaluate arithmetic expression failed is not promising

that one (scala.tools.xsbt.InteractiveConsoleInterfaceTest) is reproducible locally and is also a colorized-vs-not difference. perhaps that's the sole cause of the various failures?

[SethTisue]

Properties#coloredOutputEnabled is coming out differently because (in the context of InteractiveConsoleInterfaceTest) System.console() returns null on JDK 21 but on JDK 22 it returns a java.io.ProxyingConsole

[SethTisue]

https://jdk.java.net/22/release-notes says:

JLine As The Default Console Provider (JDK-8308591)
System.console() has changed in this release to return a Console with enhanced editing features that improve the experience of programs that use the Console API. In addition, System.console() now returns a Console object when the standard streams are redirected or connected to a virtual terminal. In prior releases, System.console() returned null for these cases. This change may impact code that uses the return from System.console() to test if the VM is connected to a terminal. If needed, running with -Djdk.console=java.base will restore older behavior where the console is only returned when it is connected to a terminal.

A new method Console.isTerminal() has been added to test if console is connected to a terminal.

[SethTisue]

I guess we should call Console.isTerminal reflectively if it's available, and otherwise fallback to the old-style null test.

[som-snytt]

They also mention class file API as more stable & timely base for 3rd party libs.

https://openjdk.org/jeps/457

The console check is at scala/scala#10751

[SethTisue]

merged scala/scala#10751 but there are still test failures at https://github.com/scala/scala/actions/runs/8665032593

[SethTisue]

junit/test passes now, it's the partests that still fail

[lrytz]

-Vimplicits is still colored somehow, which is weird - it seems to go through consoleIsTerminal added in scala/scala#10751.

I noticed scala/scala#10751 (review) but that doesn't look like a possible cause for having too much color on linux.