Skip to content

upgrade to Scala 2.13.4 #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

upgrade to Scala 2.13.4 #389

wants to merge 1 commit into from

Conversation

SethTisue
Copy link
Member

@SethTisue SethTisue commented Nov 21, 2020

not for merge until a Scala 3 release is available that upgrades the standard library to 2.13.4 -- presumably that will be 3.0.0-M2. (M1 is on 2.13.3.)

I copied LazyList.scala and LazyListLazinessTest.scala straight from 2.13.4, except for the package declaration /cc @NthPortal

@NthPortal
Copy link
Contributor

I copied LazyList.scala and LazyListLazinessTest.scala straight from 2.13.4, except for the package declaration

sadly, the names and APIs are sufficiently different between 2.11/2.12 and 2.13 that I don't think we can do that. also, some of the tests for LazyList were commented out basically as a note that 2.11 or 2.12 can't support them, though I have no recollection of why.

I think we're better off trying to cherry-pick the change commits, though I don't really know how given the completely different directory structure (and the different package). I can try to have a look at doing this if I have the energy

@SethTisue
Copy link
Member Author

yeah honestly I don't think I can afford to take this on myself, then. hopefully you or another volunteer will choose to tackle it

@SethTisue SethTisue closed this Nov 21, 2020
@SethTisue
Copy link
Member Author

the Dotty PR with the 2.13.4 upgrade is scala/scala3#10392 — once it lands, a nightly could be used for testing, even before the next official release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants