Skip to content

migrates to 2.11.0-RC1 #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 27 commits into from
Closed

migrates to 2.11.0-RC1 #61

wants to merge 27 commits into from

Conversation

xeno-by
Copy link
Contributor

@xeno-by xeno-by commented Feb 15, 2014

Migrates scala/async to scala/scala#3452 that is planned to be merged into trunk before 2.11.0-RC1. No more casts to Global. No more scala.reflect.internal.SymbolTable. /cc @retronym

@retronym
Copy link
Member

Wow. This is really "above and beyond" stuff.

@xeno-by
Copy link
Contributor Author

xeno-by commented Feb 15, 2014

Updated initial commits so that they don't do anything hacky to scalaHome, etc. Now this thing could theoretically be merged after RC1 is out.

upd. I'd especially like to point out that every single commit in this chain builds and passes all the tests successfully, so you might want to keep history (or maybe even make it more fine-grained in the case of the last commit, which required me to make a bulk of changes at once) to simplify potential troubleshooting.

In the meanwhile, to take a closer look at the pull request, launch sbt using sbt -scala-version 2.11.0-SNAPSHOT -scala-home "<palladium0>/build/pack" "$@", where <palladium0> is path to a checkout of the aforementioned pull request to scala/scala.

@retronym
Copy link
Member

cheers

Protip: The PR validator publishes snapshots:

http://private-repo.typesafe.com/typesafe/scala-pr-validation-snapshots/org/scala-lang/scala-compiler/

cat ~/.sbt/0.13/global.sbt
resolvers ++= (
  if (scalaVersion.value.endsWith("-SNAPSHOT"))
    List("pr-scala snapshots" at "http://private-repo.typesafe.com/typesafe/scala-pr-validation-snapshots/")
  else
    Nil
)

@xeno-by
Copy link
Contributor Author

xeno-by commented Feb 15, 2014

Do I need to enable something special in order for SBT to pick up this config? I tried to build SBT using such a SNAPSHOT builds, it says "getting scala blah blah" and then displays a not found error with "pr-scala snapshots" not present in the list of repos it's considered.

@retronym
Copy link
Member

It might depend on where your SBT script looks for its sbt.global.home. The default value is ~/sbt/0.13.

@xeno-by
Copy link
Contributor Author

xeno-by commented Feb 15, 2014

How do I figure out where's sbt.global.home?

@retronym
Copy link
Member

@retronym retronym closed this Feb 15, 2014
@retronym
Copy link
Member

I meant to say sbt.global.base

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants