This repository was archived by the owner on Feb 23, 2018. It is now read-only.
Fix findItemByIndex in case of hash collisions #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method `findItemByIndex` only looked at the first item in each bucket of the `items` hash table. Also, in case the item was not found, the counter `i` would be at `items.length`, therefore the access `items[i]` crashed with an ArrayIndexOutOfBoundsException. Fixes the issue scala/scala-asm#8.
|
review by @adriaanm (original author of the patch lrytz/scala@34e3220) |
|
LGTM |
lrytz
added a commit
that referenced
this pull request
Jul 28, 2015
Fix findItemByIndex in case of hash collisions
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method
findItemByIndexonly looked at the first item in eachbucket of the
itemshash table.Also, in case the item was not found, the counter
iwould be atitems.length, therefore the accessitems[i]crashed with anArrayIndexOutOfBoundsException.
Fixes the issue scala/scala-asm#8.