This repository was archived by the owner on Feb 23, 2018. It is now read-only.
Support Java 9 bytecode format #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AFAIK the bytecode format was bumped to indicate that code compiled with `-target 9` requires boostrap methods that only exist in the Java 9 standard library for the new String concatenation based on invokedynamic. So we probably don't need changes to the bytecode parser/writers.
|
This is being discussed on the ASM lists (http://mail.ow2.org/wws/arc/asm/2016-05/msg00003.html), but it hasn't happened in 5.2 (we're still on 5.1 in this repo). Did you test this locally? Then we can merge this in the meantime. |
|
Yes, with this change and a handful of unrelated changes to our code base, I was able to build Scala/scala. |
|
Should I merge this and release 5.1.0-scala-2? |
|
Yes please! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AFAIK the bytecode format was bumped to indicate that
code compiled with
-target 9requires boostrap methodsthat only exist in the Java 9 standard library for the
new String concatenation based on invokedynamic. So we
probably don't need changes to the bytecode parser/writers.