Skip to content

Update SBT OSGI Version #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

isomarcte
Copy link

@isomarcte isomarcte commented Sep 20, 2020

Projects will not build on JRE 15 with the current version due to an old bug in a dependency of sbt-osgi.

See: sbt/sbt-osgi#72 and bndtools/bnd#3903

Note: This PR should not be merged until sbt/sbt-osgi#72 is merged and sbt-osgi does a release. It won't build until then.

Projects will not build on JRE 15 with the current version due to an old bug in a dependency of `sbt-osgi`.

See: sbt/sbt-osgi#72 and bndtools/bnd#3903
isomarcte added a commit to isomarcte/scala-xml that referenced this pull request Sep 20, 2020
Prior to this commit this project fails to build on JRE 15 due to an issue in a transitive dependency of `sbt-scala-module`. Attempting will yield this error.

```
[error] java.util.ConcurrentModificationException
[error]         at java.base/java.util.TreeMap.callMappingFunctionWithCheck(TreeMap.java:742)
[error]         at java.base/java.util.TreeMap.computeIfAbsent(TreeMap.java:596)
[error]         at aQute.bnd.osgi.Jar.putResource(Jar.java:288)
[error]         at aQute.bnd.osgi.Jar.buildFromZip(Jar.java:216)
[error]         at aQute.bnd.osgi.Jar.<init>(Jar.java:122)
[error]         at aQute.bnd.osgi.Jar.<init>(Jar.java:148)
[error]         at aQute.bnd.osgi.Analyzer.setClasspath(Analyzer.java:1597)
[error]         at com.typesafe.sbt.osgi.Osgi$.bundleTask(Osgi.scala:57)
[error]         at com.typesafe.sbt.osgi.SbtOsgi$.$anonfun$defaultOsgiSettings$1(SbtOsgi.scala:55)
[error]         at scala.Function1.$anonfun$compose$1(Function1.scala:49)
[error]         at sbt.internal.util.$tilde$greater.$anonfun$$u2219$1(TypeFunctions.scala:62)
[error]         at sbt.std.Transform$$anon$4.work(Transform.scala:67)
[error]         at sbt.Execute.$anonfun$submit$2(Execute.scala:281)
[error]         at sbt.internal.util.ErrorHandling$.wideConvert(ErrorHandling.scala:19)
[error]         at sbt.Execute.work(Execute.scala:290)
[error]         at sbt.Execute.$anonfun$submit$1(Execute.scala:281)
[error]         at sbt.ConcurrentRestrictions$$anon$4.$anonfun$submitValid$1(ConcurrentRestrictions.scala:178)
[error]         at sbt.CompletionService$$anon$2.call(CompletionService.scala:37)
[error]         at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
[error]         at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
[error]         at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
[error]         at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1130)
[error]         at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:630)
[error]         at java.base/java.lang.Thread.run(Thread.java:832)
[error] (xml / osgiBundle) java.util.ConcurrentModificationException
```

See,
* bndtools/bnd#3903
* sbt/sbt-osgi#72
* scala/sbt-scala-module#102
@SethTisue SethTisue marked this pull request as draft September 29, 2020 18:40
@SethTisue SethTisue self-assigned this Sep 29, 2020
@SethTisue
Copy link
Member

oh I merged #103 without remembering this earlier PR was here. thank you for calling this to our attention

@SethTisue SethTisue closed this Sep 30, 2020
@SethTisue
Copy link
Member

I also published sbt-scala-module 2.2.2 to make the change available

SethTisue pushed a commit to isomarcte/scala-xml that referenced this pull request Sep 30, 2020
Prior to this commit this project fails to build on JRE 15 due to an
issue in a transitive dependency of `sbt-scala-module`. Attempting
will yield this error.

```
[error] java.util.ConcurrentModificationException
[error]         at java.base/java.util.TreeMap.callMappingFunctionWithCheck(TreeMap.java:742)
[error]         at java.base/java.util.TreeMap.computeIfAbsent(TreeMap.java:596)
[error]         at aQute.bnd.osgi.Jar.putResource(Jar.java:288)
[error]         at aQute.bnd.osgi.Jar.buildFromZip(Jar.java:216)
[error]         at aQute.bnd.osgi.Jar.<init>(Jar.java:122)
[error]         at aQute.bnd.osgi.Jar.<init>(Jar.java:148)
[error]         at aQute.bnd.osgi.Analyzer.setClasspath(Analyzer.java:1597)
[error]         at com.typesafe.sbt.osgi.Osgi$.bundleTask(Osgi.scala:57)
[error]         at com.typesafe.sbt.osgi.SbtOsgi$.$anonfun$defaultOsgiSettings$1(SbtOsgi.scala:55)
[error]         at scala.Function1.$anonfun$compose$1(Function1.scala:49)
[error]         at sbt.internal.util.$tilde$greater.$anonfun$$u2219$1(TypeFunctions.scala:62)
[error]         at sbt.std.Transform$$anon$4.work(Transform.scala:67)
[error]         at sbt.Execute.$anonfun$submit$2(Execute.scala:281)
[error]         at sbt.internal.util.ErrorHandling$.wideConvert(ErrorHandling.scala:19)
[error]         at sbt.Execute.work(Execute.scala:290)
[error]         at sbt.Execute.$anonfun$submit$1(Execute.scala:281)
[error]         at sbt.ConcurrentRestrictions$$anon$4.$anonfun$submitValid$1(ConcurrentRestrictions.scala:178)
[error]         at sbt.CompletionService$$anon$2.call(CompletionService.scala:37)
[error]         at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
[error]         at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
[error]         at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
[error]         at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1130)
[error]         at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:630)
[error]         at java.base/java.lang.Thread.run(Thread.java:832)
[error] (xml / osgiBundle) java.util.ConcurrentModificationException
```

See,
* bndtools/bnd#3903
* sbt/sbt-osgi#72
* scala/sbt-scala-module#102
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants