small changes throughout release notes #233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typos, wording changes, formatting changes
lrytz
approved these changes
Nov 7, 2016
|
|
||
| * compile under `-Xsource:2.11` | ||
| * use an explicit call to the conversion method | ||
| * disqualify the type from being a SAM (e.g. by adding a second abstract method). |
There was a problem hiding this comment.
need to check if this will work with scala-lang's markdown parser.. the rest of the file uses a different style for bullets.
adriaanm
reviewed
Nov 7, 2016
| @@ -1,93 +1,120 @@ | |||
| We are very happy to announce the availability of Scala 2.12.0! | |||
|
|
|||
| ## Headline features | |||
|
|
|||
| The Scala 2.12 compiler has been completely overhauled to make use of the new VM features available in Java 8: | |||
|
|
|||
| - A trait [compiles directly to an interface](#trait-compiles-to-an-interface) with default methods. This improves binary compatibility and Java interoperability. | |||
There was a problem hiding this comment.
This link will need to be updated due to change to header below.
There was a problem hiding this comment.
#traits-compile-to-interfaces
adriaanm
previously requested changes
Nov 7, 2016
| @@ -1,93 +1,120 @@ | |||
| We are very happy to announce the availability of Scala 2.12.0! | |||
|
|
|||
| ## Headline features | |||
|
|
|||
| The Scala 2.12 compiler has been completely overhauled to make use of the new VM features available in Java 8: | |||
|
|
|||
| - A trait [compiles directly to an interface](#trait-compiles-to-an-interface) with default methods. This improves binary compatibility and Java interoperability. | |||
There was a problem hiding this comment.
#traits-compile-to-interfaces
|
While you're at it, could you add a reference to the removal of the rewrite from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typos, wording changes, formatting changes, some reordering towards the top
review by @adriaanm
if merged, I'll take care of propagating the changes to the blog post and the GitHub milestone
this is a lot easier to review with
git show --word-diff