Make sure modules are built and published using the final release #120
Conversation
| @@ -187,30 +187,39 @@ sbtResolve() { | |||
| # then set the version to the right one and publish (which won't re-gen the docs). | |||
| # Also tried publish-local without docs using 'set publishArtifact in (Compile, packageDoc) := false' and republishing, no dice. | |||
|
|
|||
| # Each buildModule() function is invoked twice: first to build against locker and publish to private-repo, then | |||
| # to build against the release and publish to sonatype (or publish-local if publishToSonatype is not "yes"). | |||
| # In the second round, sbtResolve is always true: the module will be found in the private-repo! | |||
There was a problem hiding this comment.
This change will work, but maybe we should instead have two sbtResolve functions? One that looks in private-repo and one that doesn't?
There was a problem hiding this comment.
that sounds much better, yes.
There was a problem hiding this comment.
the sbtResolve should never look in private-repo, no?
There was a problem hiding this comment.
True! (Assuming we can still overwrite in private-repo, but I think we can. I remember some sbt discussions about this, but not sure about the outcome. /cc @eed3si9n: the internal bootstrapping part of this release scripts is IMO a good exception to the rule that artifacts must never be overwritten -- what's the plan for sbt's publish task and overwriting artifacts?)
|
@adriaanm PTAL |
|
|
||
| # Create a version of 'repositories-scala-release' without the 'private-repo'. | ||
| # sbtResolve should not check in the private-repo, see its doc. | ||
| cat $scriptsDir/repositories-scala-release | grep -v private-repo > $baseDir/resolutionScratch_/repositories-without-private-repo |
There was a problem hiding this comment.
EDIT: never mind, other stuff wil break if $baseDir has spaces.
"$baseDir/resolutionScratch_/repositories-without-private-repo" in case $baseDir has spaces
|
LGTM |
|
Hmm, in fact this solution does not work. The problem is that I'll go back to the previous solution for now. |
|
ah yes -- a lot of trickery involved here :( |
Make sure modules are built and published using the final release
No description provided.