Skip to content

Fix code sample in reflection overview #935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2017

Conversation

marconilanna
Copy link
Contributor

@marconilanna marconilanna commented Nov 24, 2017

Fix the following issues:

  1. Deprecated methods declarations/declaration replaced with decls/decl;
  2. decls used instead of decl
  3. Links to current Scaladoc;
  4. Typo in Japanese docs: meber

@@ -171,7 +171,7 @@ which makes all classes and types available that are loaded by the classloader
that also loaded the class of `p` (`Purchase`), which we need in order to
access member `shipped`.

scala> val shippingTermSymb = ru.typeOf[Purchase].decls(ru.TermName("shipped")).asTerm
scala> val shippingTermSymb = ru.typeOf[Purchase].declaration(ru.TermName("shipped")).asTerm
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that declaration is deprecated in favor of decl these days...

@marconilanna
Copy link
Contributor Author

@hrhino thanks for point that out. fixed.

@marconilanna marconilanna mentioned this pull request Dec 5, 2017
@SethTisue SethTisue merged commit 0998b71 into scala:master Dec 5, 2017
@SethTisue
Copy link
Member

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants