Skip to content

Fix code style by removing :fail from lower-type-bounds.md #859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 11, 2017
Merged

Fix code style by removing :fail from lower-type-bounds.md #859

merged 2 commits into from
Aug 11, 2017

Conversation

ayurchuk
Copy link

@ayurchuk ayurchuk commented Aug 11, 2017

Existing documentation layout:
screen shot 2017-08-11 at 13 58 58
screen shot 2017-08-11 at 14 53 19
Expected one:
screen shot 2017-08-11 at 13 59 50
screen shot 2017-08-11 at 14 54 52

@ayurchuk ayurchuk changed the title Fix code style be removing :fail from lower-type-bounds.md Fix code style by removing :fail from lower-type-bounds.md Aug 11, 2017
@heathermiller
Copy link
Member

Ah! Thanks for catching this. Actually, I think the solution is for me to add tut:fail to this silly little Jekyll plugin I made so that this is correctly rewritten to a scala fenced code block after tut runs... Hang on, let me see...

@heathermiller heathermiller merged commit 3be9890 into scala:master Aug 11, 2017
@heathermiller
Copy link
Member

@ayurchuk I think I got it! Fixed it in this little Jekyll plugin we have for making syntax highlighting place nicely with tut. See #860

Thank you so much for reporting this and for taking a first step at a fix! It's sincerely appreciated! ❤️

heathermiller added a commit that referenced this pull request Aug 11, 2017
Add tut:fail and tut:nofail to Jekyll plugin tweaks #859
@ayurchuk ayurchuk deleted the fix_code_block_style branch August 11, 2017 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants