Skip to content

Updating Utilities Section in SIP 14 #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2012
Merged

Conversation

vjovanov
Copy link
Contributor

@vjovanov vjovanov commented Apr 4, 2012

No description provided.

heathermiller added a commit that referenced this pull request Apr 4, 2012
Updating Utilities Section in SIP 14
@heathermiller heathermiller merged commit c572252 into scala:master Apr 4, 2012
@jsuereth
Copy link
Contributor

jsuereth commented Apr 4, 2012

A bit late for this, but a quick question:

Where does the implicit come from so you can write 5 millis? It's not specified in the document nor do the examples show a place for the implicit that is not under TimeUnits (and odd place for it).

@vjovanov
Copy link
Contributor Author

vjovanov commented Apr 4, 2012

It is not agreed upon yet so I did not put it in the SIP. Before it was in the package object but now it lives in DurationImplicits object. However Akka has them in scala.concurrent.util.duration package object. I will resolve this and submit the new pull request tomorrow.

@jsuereth
Copy link
Contributor

jsuereth commented Apr 4, 2012

Sounds good. We'll be releasing our vote shortly, but that detail was holding up our final decision.

@vjovanov
Copy link
Contributor Author

vjovanov commented Apr 4, 2012

It is fixed with the latest pull request. I did not know that was holding the SIP it would be fixed earlier.

@jsuereth
Copy link
Contributor

jsuereth commented Apr 4, 2012

Well, we hadn't finished meeting about SIPS until today :) Fast fix, thanks much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants