Link to an associated tutorial entry on singletons #612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarrodu
reviewed
Oct 30, 2016
| @@ -43,7 +43,7 @@ object Classes { | |||
| } | |||
| ``` | |||
|
|
|||
| The program defines an executable application Classes in form of a top-level singleton object with a `main` method. The `main` method creates a new `Point` and stores it in value `pt`. Note that values defined with the `val` construct are different from variables defined with the `var` construct (see class `Point` above) in that they do not allow updates; i.e. the value is constant. | |||
| The program defines an executable application Classes in form of a top-level [singleton object](singleton-objects.html) with a `main` method. The `main` method creates a new `Point` and stores it in value `pt`. Note that values defined with the `val` construct are different from variables defined with the `var` construct (see class `Point` above) in that they do not allow updates; i.e. the value is constant. | |||
There was a problem hiding this comment.
I prefer links without the extension. It gives a cleaner experience.
[singleton object](singleton-objects)
There was a problem hiding this comment.
It seems like the links are not consistent in the tutorial. I guess either is fine. Maybe I will go through and get rid of all the extensions in the future. Cheers. :-)
There was a problem hiding this comment.
One can probably do it in one pass with sed
There was a problem hiding this comment.
For sure. It would still need different PR. 👍
just to make it cleaner
jarrodu
approved these changes
Oct 30, 2016
|
LGTM, thanks guys! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.