Skip to content

Add improvements to completed and pending SIPs #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 26, 2016
Merged

Add improvements to completed and pending SIPs #586

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e60b240
Modify titles of SIP-27, SIP-28 and SIP-29
jvican Sep 26, 2016
d5032ce
Move the Trailing Commas SIP to completed
jvican Sep 26, 2016
1c0ad1d
Put correct date for September minutes
jvican Sep 26, 2016
c0eeb23
Modify formatting errors in Inline Meta SIP
jvican Sep 26, 2016
3c5e664
Add status to pending posts and modify css
jvican Sep 26, 2016
8c15419
Go back to `Not Accepted` and capitalize it
jvican Sep 26, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions _includes/allsids.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,15 @@
{% elsif post.vote-status == 'deferred' %}
<span class="label warning">Deferred</span>
{% elsif post.vote-status == 'postponed' %}
<span class="label warning">Postponed</span>
<span class="label light-warning">Postponed</span>
{% elsif post.vote-status == 'under review' %}
<span class="label warning">Under review</span>
{% elsif post.vote-status == 'numbered' %}
<span class="label notice">Numbered</span>
{% elsif post.vote-status == 'not accepted' %}
<span class="label danger">Not Accepted</span>
<span class="label danger">Rejected</span>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, so historical fact: we originally used the phrase Martin was concerned that a big red "rejected" badge was too negative so a grey "not accepted" badge was proposed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was it changed back to Rejected? I was surprised by the language. Just curious.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know. This is why I pointed out the historical background. @jvican made the call.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Being rejected is one of the greatest fears for a lot of people.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know your impressions, but when I saw it I thought it was a big euphemism. I wouldn't be afraid of just saying rejected, which is what it is. Also, not accepted is a difficult vote status to guess.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it is just a cultural difference. I am from the US. I agree that rejected works and is an accurate use of the word but to some it will have a negative connotation.

Copy link
Member

@heathermiller heathermiller Sep 26, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Euphemism is maybe the wrong word. It is less harsh to say "not accepted" rather than "rejected." Both are accurate, one just has a less negative connotation, which after you spend a lot of time proposing a change only to find that it wasn't accepted, may be what one needs. Less negativity. Maybe we should go back to "not accepted," Jorge? It was a strong preference of many a few years ago to do it this way. And I would also lean on keeping "not accepted" personally, myself.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "not accepted" is better, too

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, let's keep it then. I will keep the rejected status though (it's something not visible from the outside, only to jekyll).

{% elsif post.vote-status == 'rejected' %}
<span class="label danger">Rejected</span>
{% endif %}
{% endif %}
</li>
Expand Down
12 changes: 12 additions & 0 deletions _includes/toc.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,18 @@
<strong style="font-size: 15px;">Postponed To A Future Release</strong>
<p style="padding-top: 10px">{{ page.vote-text }}</p>
</div>
{% elsif page.vote-status == 'numbered' %}
<p class="contents">SIP Committee Decision</p>
<div class="alert-message warning" style="margin-left: 15px;">
<strong style="font-size: 15px;">Numbered</strong>
<p style="padding-top: 10px">{{ page.vote-text }}</p>
</div>
{% elsif page.vote-status == 'under review' %}
<p class="contents">SIP Committee Decision</p>
<div class="alert-message warning" style="margin-left: 15px;">
<strong style="font-size: 15px;">Under review</strong>
<p style="padding-top: 10px">{{ page.vote-text }}</p>
</div>
{% elsif page.vote-status == 'rejected' %}
<p class="contents">SIP Committee Decision</p>
<div class="alert-message danger" style="margin-left: 15px;">
Expand Down
3 changes: 2 additions & 1 deletion resources/stylesheets/bootstrap.css
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions ...ding/_posts/2016-06-25-trailing-commas.md → ...eted/_posts/2016-06-25-trailing-commas.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,10 @@
layout: sip
disqus: true
title: SIP-27 - Trailing Commas
---

# SIP-27: Trailing Commas
vote-status: accepted
vote-text: The following proposal needs to be updated, since only the specialized case version (with new lines) has been accepted. For more information, check the <a href="http://docs.scala-lang.org/sips/minutes/sip-20th-september-minutes.html">minutes</a>.
---

**By: Dale Wijnand**

Expand Down
0 .../2016-08-20-sip-20th-september-minutes.md → .../2016-09-20-sip-20th-september-minutes.md
View file
Open in desktop
File renamed without changes.
2 changes: 2 additions & 0 deletions sips/pending/_posts/2013-05-31-improved-lazy-val-initialization.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ layout: sip
disqus: true
title: SIP-20 - Improved Lazy Vals Initialization

vote-status: under review
vote-text: Next iteration takes place in October 2016.
---

**By: Aleksandar Prokopec, Miguel Garcia, Jason Zaugg, Hubert Plociniczak, Viktor Klang, Martin Odersky**
Expand Down
3 changes: 3 additions & 0 deletions sips/pending/_posts/2013-06-10-spores.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@
layout: sip
disqus: true
title: SIP-21 - Spores

vote-status: under review
vote-text: Next iteration takes place in November 2016. Check <a href="http://localhost:4000/sips/minutes/sip-20th-september-minutes.html">September's minutes</a>.
---

**By: Heather Miller, Martin Odersky, and Philipp Haller**
Expand Down
3 changes: 3 additions & 0 deletions sips/pending/_posts/2013-06-30-async.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@
layout: sip
disqus: true
title: SIP-22 - Async

vote-status: postponed
vote-text: Authors have asked to postpone until further notice. They will eventually open the proposal when some details in the implementation are ready. Check <a href="http://localhost:4000/sips/minutes/sip-minutes.html">July's minutes</a>.
---

**By: Philipp Haller and Jason Zaugg**
Expand Down
9 changes: 5 additions & 4 deletions sips/pending/_posts/2016-09-09-inline-meta.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
---
layout: sip
disqus: true
title: SIP-NN - Inline/meta
---
title: SIP-28 and SIP-29 - Inline meta

# SIP-NN: Inline/meta
vote-status: numbered
vote-text: The following proposal has been split and numbered as SIP-28 (Inline) and SIP-29 (Meta). For more information on this decision, check the <a href="http://docs.scala-lang.org/sips/minutes/sip-20th-september-minutes.html">minutes</a>.
---

**By: Eugene Burmako, Sébastien Doeraene, Vojin Jovanovic, Martin Odersky, Dmitry Petrashko, Denys Shabalin**

Expand Down Expand Up @@ -1020,4 +1021,4 @@ mandated by the SIP process.
[FeedbackWebsite]: http://gitter.im/scalameta/sips
[AppendixInteraction]: https://gist.github.com/xeno-by/e26a904051a171e4bc8b9096630220a7
[AppendixExpansion]: https://gist.github.com/xeno-by/5dde62aedcc23afc85ecf4d795ac67c2
[AppendixMeta]: https://gist.github.com/xeno-by/9741ce7532cb30368b3753521bbfce4e
[AppendixMeta]: https://gist.github.com/xeno-by/9741ce7532cb30368b3753521bbfce4e