Skip to content

Italian translation added #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 1, 2016
Merged

Italian translation added #453

merged 3 commits into from
Apr 1, 2016

Conversation

indaco
Copy link
Contributor

@indaco indaco commented Sep 6, 2015

Added Italian translation for the tutorial. It is a good opportunity to review what I previously did in 2009 - http://bit.ly/1EJepIK

Italian translation for the tutorial  added. It is a good opportunity
to review what I previously did in 2009 -  http://bit.ly/1EJepIK
@SethTisue
Copy link
Member

@cunei, might you be interested in reviewing this? (or could you suggest an Italian-speaking reviewer?)

@cunei
Copy link

cunei commented Sep 11, 2015

@SethTisue, I can review this text. An additional reviewer could be @dotta

@heathermiller
Copy link
Member

Awesome! Awaiting a review by @cunei or @dotta before merging. Thanks Toni :)

@dickwall
Copy link
Contributor

dickwall commented Nov 2, 2015

Ping @cunei or @dotta - trying to get this PR unstuck with a review. Thanks

@SethTisue
Copy link
Member

@cunei, @dotta?

Per compilare l'esempio useremo `scalac`, il compilatore Scala.
`scalac` lavora come la maggior parte dei compilatori: prende un file
sorgente come argomento, eventuali opzioni e produce uno o più object
file come output. Gli object file sono gli standard file delle classi
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/object file/class file

Also considering that in the next paragraph class file is used already.

@dotta
Copy link

dotta commented Dec 18, 2015

@indaco Great stuff! I had a few comments, but overall it looks pretty good to me!

@SethTisue I've reviewed a good chunk of it, and will try to finish it off next week. However, I haven't read the original text, so mine is not a translation review (just pointing it out, not sure you guys care).

diversi tipi di contenitori sono basati sugli alberi, come gli alberi
red-black.

Esamineremo ora come gli alberi sono rappresentati e manipolati in Scala
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of "sono", I think it's better to say "possono essere".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll fix it

@SethTisue
Copy link
Member

thanks Mirco! I'd suggest a new ticket with your feedback on the content. that feedback is valuable.

this PR specifically is mergeable as long as there aren't glaring translation mistakes.

valore al nome di una variabile. L’environment `{ x -> 5 }`
mostrato sopra può essere semplicemente scritto in Scala come:

{ case "x" => 5 }
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why using a partial function and not a plain function?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aaah, I see, just reading what comes next. OK then.

@dotta
Copy link

dotta commented Dec 18, 2015

@SethTisue Alright, I've just decided to do it all in one pass otherwise I'll forget again :-) I'd definitely say the PR is good to merge, no glaring mistakes in the text itself, but I don't know how much it differs from the original text. Feel free to create tickets as needed.

@dotta
Copy link

dotta commented Dec 18, 2015

By the way, @cunei, you are such a slacker! :-P

@indaco
Copy link
Contributor Author

indaco commented Apr 1, 2016

Although most of your comments are valuable I just want to clarify that I I simply use the original english tutorial, maybe it's time to update the original one :-) in order to be updated with the latest scala and java 8 features.

What's your thoughts?

@SethTisue SethTisue merged commit 5bfdd58 into scala:master Apr 1, 2016
@dotta
Copy link

dotta commented Apr 1, 2016

@indaco Ciao Mirco! No worries, I was asked to review the text and did so, but also pointed out that I didn't read the original :-) I'm actually surprised @SethTisue hasn't merged this PR yet.

I think it'd be great to update the original text. If you have time, I'm sure your contribution would be highly valued!

By the way, thanks again - a lot - for the really great translation!

@SethTisue
Copy link
Member

I think it was just an oversight that this wasn't merged a while ago. thank you, @indaco.

yeah, and yeah, the content just gradually gets more and more outdated. :-\

@dotta
Copy link

dotta commented Apr 1, 2016

oh, here is @SethTisue :-)

@SethTisue
Copy link
Member

jinx!

@indaco
Copy link
Contributor Author

indaco commented Apr 1, 2016

:-) Thank you

@SethTisue
Copy link
Member

whoops, this broke the site build: https://travis-ci.org/scala/scala.github.com/builds/120106186

I'm investigating.

@indaco
Copy link
Contributor Author

indaco commented Apr 1, 2016

oh no!

@SethTisue
Copy link
Member

no worries, easy fix: b19591b

this is showing up on the site now: there is an "Italiano" link at http://docs.scala-lang.org/tutorials/scala-for-java-programmers.html

(fwiw, note that Travis would normally catch a bug like this pre-merge, but that didn't happen here because this PR predates the addition of Travis to the repo.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants