Execution context #304

backuitist · 2014-02-19T09:38:16Z

I've integrated some of your comments ;)

backuitist · 2014-02-19T09:40:05Z

overviews/core/_posts/2012-09-20-futures.md

+
+### The Global Execution Context
+
+`ExecutionContext.global` is an `ExecutionContext` backed by a [ForkJoinPool](http://docs.oracle.com/javase/tutorial/essential/concurrency/forkjoin.html). It should be sufficient for most situations but requires some care.  


Look i've changed the link. But you might want to remove it as it points at http://docs.oracle.com/javase/7/docs/api/java/util/concurrent/ForkJoinPool.html ?

I don't think there is a license problem with pointing back to Oracle's Java documentation.

Please break these two sentences into two lines.

I'm having second thoughts about mentioning FJ pool here.
The current ExecutionContext.global implementation, even though it's unlikely to change,
should be mentioned at most in the ScalaDoc API.
Otherwise, our documentation is too flaky, and it becomes hard to maintain the crossreferences.

This doc should discuss only the high-level usage and meaning of execution contexts,
not the specific implementation.
It is also unclear if we should mention minThreads, numThreads and maxThreads configuration settings,
since they are not mentioned explicitly in the API docs.

I would suggest that you refactor this section, so that all mention of ForkJoinPool is put in a separate section,
entitled e.g. "Execution Contexts based on Fork/Join Pools".

I disagree, references of ExecutionContext.global are all over that documentation. So you might be right in theory, but in practice people will be using (and abusing) the global EC. Documenting how this works and flagging potential issues isn't low-level details.

I would suggest that you refactor this section, so that all mention of ForkJoinPool is put in a separate section,
entitled e.g. "Execution Contexts based on Fork/Join Pools".

That's actually what I did by wrapping FJP details into the The Global Execution Context section.

SethTisue · 2015-07-23T14:26:32Z

review by @viktorklang and @axel22?

axel22 · 2015-07-23T19:05:01Z

overviews/core/_posts/2012-09-20-futures.md

@@ -36,6 +36,134 @@ in the case of an application which requires blocking futures, for an underlying
 environment to resize itself if necessary to guarantee progress.
 -->

+A typical future look like this:
+
+    val inverseFuture : Future[Matrix] = Future {


We normally write the type ascription immediately after the identifier, without the space:

val inverseFuture: Future[Matrix] = ...

I recommend making the example take the EC as an implicit parameter to foster a culture of getting the EC passed in rather than defining it locally.

Agree - the more idiomatic version below could be sufficient.

axel22 · 2015-07-23T19:36:52Z

Thanks a lot for taking the effort to improve the documentation to this extent!
Please address my comments before we can merge this in.

viktorklang · 2015-07-24T10:17:36Z

overviews/core/_posts/2012-09-20-futures.md

+Futures provide a way to reason about performing many operations
+in parallel-- in an efficient and non-blocking way. 
+A [Future](http://www.scala-lang.org/api/current/index.html#scala.concurrent.Future) 
+is a sort of a placeholder object that you can create for a result that does not yet exist. 


I'd suggest:

is a placeholder object for a value that may not yet exist.

SethTisue · 2015-08-23T23:11:37Z

@backuitist interested in getting this across the finish line...?

backuitist · 2015-08-24T08:25:49Z

Sorry, that went off my radar.

SethTisue · 2015-09-02T19:40:09Z

@axel22 @viktorklang lgty now?

axel22 · 2015-09-07T20:32:30Z

I would fix that one last colon, but it looks good to me.

SethTisue · 2015-09-11T15:42:49Z

yay, across the finish line! thank you @backuitist for your great patience, thank you reviewers. (@viktorklang, it's of course not too late for further changes.)

Execution context

viktorklang · 2015-09-11T17:43:00Z

@SethTisue :-)

execution context

6c22f79

backuitist reviewed Feb 19, 2014
View reviewed changes

axel22 reviewed Jul 23, 2015
View reviewed changes

viktorklang reviewed Jul 24, 2015
View reviewed changes

backuitist force-pushed the execution-context branch 2 times, most recently from a34a8a3 to ec26bab Compare August 24, 2015 09:07

backuitist force-pushed the execution-context branch from ec26bab to c690c20 Compare August 24, 2015 09:11

address PR comments

c346d1e

backuitist force-pushed the execution-context branch from c690c20 to c346d1e Compare September 8, 2015 06:40

SethTisue added a commit that referenced this pull request Sep 11, 2015

Merge pull request #304 from backuitist/execution-context

fcb6c7b

Execution context

SethTisue merged commit fcb6c7b into scala:master Sep 11, 2015


		### The Global Execution Context

		`ExecutionContext.global` is an `ExecutionContext` backed by a [ForkJoinPool](http://docs.oracle.com/javase/tutorial/essential/concurrency/forkjoin.html). It should be sufficient for most situations but requires some care.

Execution context #304

Execution context #304

Uh oh!

Conversation

backuitist commented Feb 19, 2014

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SethTisue commented Jul 23, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

axel22 commented Jul 23, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SethTisue commented Aug 23, 2015

Uh oh!

backuitist commented Aug 24, 2015

Uh oh!

SethTisue commented Sep 2, 2015

Uh oh!

axel22 commented Sep 7, 2015

Uh oh!

SethTisue commented Sep 11, 2015

Uh oh!

viktorklang commented Sep 11, 2015

Uh oh!

Uh oh!