Skip to content

Update some compiler options #2727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 10, 2023
Merged

Conversation

som-snytt
Copy link
Contributor

Updated for a few major features.

It would be nice to automate or at least automatically verify.

Copy link
Contributor

@julienrf julienrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @som-snytt! The changes look good to me, but I would like someone from the Scala 3 compiler team to also have a look at them.

@julienrf julienrf requested a review from Kordyjan March 9, 2023 10:07
Copy link
Contributor

@prolativ prolativ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to keep things ordered alphabetically, then -Vdebug, -Vlog:<phases> and -Wself-implicit should be moved. Otherwise LGTM

@som-snytt
Copy link
Contributor Author

Improved alphabetic order, added new options (they keep adding options), removed old aliases as a matter of policy.

Checked order against scalac -help, scalac -V, etc.

Tragically, I moved -V and -W to the front and lost the useful diff. Sorry about that.

Worth motivating that order, aside from the alphabet. As a user, I want more info (-V) or maybe more safety (-W). If I'm an advanced user, I might use an advanced option (-X). In the privacy of my own home or cubicle, I might add a private option (-Y) if no one is looking over my shoulder.

@julienrf
Copy link
Contributor

Thank you!

@julienrf julienrf merged commit 6d303fa into scala:main Mar 10, 2023
@som-snytt som-snytt deleted the issue/2615-options branch March 10, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants