Update implicit-conversions.md #2674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure if it is intentional, but the Tour-of-Scala documentation does not mention how to bring implicit conversions into scope. In fact, that information is a bit hard to find anywhere else, so I thought I'll propose to add it here?
bishabosha
reviewed
Jan 18, 2023
bishabosha
reviewed
Jan 18, 2023
Co-authored-by: Jamie Thompson <bishbashboshjt@gmail.com>
Improved Scala 3 description. Thanks for all the suggestions!
bishabosha
reviewed
Jan 18, 2023
bishabosha
reviewed
Jan 18, 2023
Co-authored-by: Jamie Thompson <bishbashboshjt@gmail.com>
bishabosha
approved these changes
Jan 19, 2023
bishabosha
reviewed
Jan 19, 2023
|
I've just remembered that you wrote all this when the next section "How are implicit conversions selected" is supposed to answer this point, by linking to the scala FAQ, maybe it would be good to merge the sections |
bishabosha
reviewed
Jan 19, 2023
Sorry for wasting your time, next time, I'll install the toolchain.
Ok, that makes sense :) |
bishabosha
approved these changes
Jan 19, 2023
Thanks for being patient, too! I’m happy to have contributed. 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if it is intentional, but the Tour-of-Scala documentation does not mention how to bring implicit conversions into scope. In fact, that information is a bit hard to find anywhere else, so I thought I'll propose to add it here?