Skip to content

update tour/implicit-conversions for Scala 3 #2630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 9, 2022
Merged

update tour/implicit-conversions for Scala 3 #2630

merged 2 commits into from
Nov 9, 2022

Conversation

bishabosha
Copy link
Member

adapt Tour of Scala implicit conversions page for scala 3

@bishabosha bishabosha requested a review from julienrf November 8, 2022 14:11
@bishabosha bishabosha mentioned this pull request Nov 8, 2022
Open
julienrf
julienrf requested changes Nov 9, 2022
View reviewed changes
Copy link
Contributor

@julienrf julienrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Jamie. I would expect also an explanation of where does the compiler search conversions. It can be a link to the implicit-parameters page maybe?

@bishabosha bishabosha requested a review from julienrf November 9, 2022 10:05
@bishabosha bishabosha force-pushed the tour-implicit-conversions branch from c7e239a to b679db2 Compare November 9, 2022 10:07
julienrf
julienrf reviewed Nov 9, 2022
View reviewed changes
julienrf
julienrf approved these changes Nov 9, 2022
View reviewed changes
Copy link
Contributor

@julienrf julienrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good to go, even though I would still expect an explanation of where the compiler searches for conversions. That could be added later.

@bishabosha bishabosha merged commit b45c4c5 into scala:main Nov 9, 2022
@bishabosha bishabosha deleted the tour-implicit-conversions branch November 9, 2022 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrf julienrf julienrf approved these changes

Assignees

@julienrf julienrf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bishabosha @julienrf