Skip to content

Add snippet tabs for collections in scala3book #2614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 31, 2022

Conversation

rochala
Copy link
Contributor

@rochala rochala commented Oct 24, 2022

This is PR to add snippet tabs for completions.
There are some problems with syntax highlighting:
image
and
image
Which code is here

I also added Union type example for lists with generic types here

Should i leave it as it is or remove union type example ?

Copy link
Member

@bishabosha bishabosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some braces needed in two examples

@rochala rochala requested a review from bishabosha October 27, 2022 18:43
@julienrf julienrf changed the title Add snippet tabs for completions in scala3book Add snippet tabs for collections in scala3book Oct 28, 2022
Copy link
Member

@bishabosha bishabosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants