Skip to content

Delete actors-migration-guide.md #2604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2022
Merged

Delete actors-migration-guide.md #2604

merged 1 commit into from
Oct 30, 2022

Conversation

Khalian
Copy link
Contributor

@Khalian Khalian commented Oct 13, 2022

Remove scala actors migration guide : #2542

@bishabosha
Copy link
Member

This should also delete the various translation, and remove and links to this page, e.g. from the index pages

@Khalian
Copy link
Contributor Author

Khalian commented Oct 18, 2022

This should also delete the various translation, and remove and links to this page, e.g. from the index pages

Yea I know. I just made the change.

My apologies. This is my first time working on this repo and I did not know where all its present at first. I removed the dependencies but I do not know if I can run the approval workflow on my own (so as to not waste maintainer time).

Copy link
Member

@bishabosha bishabosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you also need to delete _zh-cn/overviews/core/actors-migration-guide.md, and any links to that (tho I think you have), you can run the proofer locally with

bundle exec htmlproofer ./_site/\
             --only-4xx\
             --http-status-ignore "400,401,403,429"\
             --empty-alt-ignore\
             --allow-hash-href\
             --url-ignore '/https://github.com/scala/docs.scala-lang/blob/main/.*/,/www.oracle.com/'

taken from build.yml although for me the --url-ignore option did not work

@bishabosha
Copy link
Member

bishabosha commented Oct 18, 2022

My apologies. This is my first time working on this repo and I did not know where all its present at first.

Its ok :) I'm sorry if I was too direct. Thank you for taking the original initiative!

Remove scala actors migration guide : #2542
@Khalian
Copy link
Contributor Author

Khalian commented Oct 22, 2022

Yea I think I got rid of the links already. Now just deleted: _zh-cn/overviews/core/actors-migration-guide.md

I have a bunch of ruby gems to install on my mac and there are some issues so could not yet run bundle locally.

It would be nice if the workflow was auto run instead of asking for a maintainer to run it. This way the CI/CD system would provide immediate feedback and the project maintainers can still enforce that only they can merge it pending a passed test and review.

@bishabosha
Copy link
Member

I have a bunch of ruby gems to install on my mac and there are some issues so could not yet run bundle locally.

you can try running with docker docker-compose up if you have that installed?

@Khalian
Copy link
Contributor Author

Khalian commented Oct 28, 2022

Yea I do. I am gonna give it a try today.

Btw the builds passed (after I removed [_zh-cn/overviews/core/actors-migration-guide.md) and the branch has no conflicts.

@Khalian Khalian requested a review from bishabosha October 28, 2022 19:22
Copy link
Member

@bishabosha bishabosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants