Skip to content

add code tabs in num20. #2590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 19, 2022

Conversation

benluo
Copy link
Contributor

@benluo benluo commented Oct 6, 2022

No description provided.

Copy link
Member

@bishabosha bishabosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think a follow up PR can deal with the enums to provide scala 2 alternative

@bishabosha bishabosha force-pushed the _overview/scala3-book/num20-code-tabs branch from 1ee5ae6 to 1b215de Compare October 18, 2022 16:06
Copy link
Member

@bishabosha bishabosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think a separate PR can handle the lack of enums in scala 2

@bishabosha bishabosha merged commit a089649 into scala:main Oct 19, 2022
@benluo benluo deleted the _overview/scala3-book/num20-code-tabs branch October 19, 2022 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants