Skip to content

add html file lines in all files in scala3-book. change overviews links. #2562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

benluo
Copy link
Contributor

@benluo benluo commented Sep 24, 2022

add html file lines in all files in scala3-book. change overviews links.

Copy link
Member

@bishabosha bishabosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but please could you also add to all the English pages front matter

languages: [zh-cn]

you can look at how it was done in #2563

@bishabosha bishabosha self-requested a review September 27, 2022 14:17
Copy link
Member

@bishabosha bishabosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at least one page (_overviews/scala3-book/where-next.md) has broken links due to translations not being provided yet

@benluo benluo requested a review from bishabosha September 27, 2022 15:03
@bishabosha bishabosha merged commit d390276 into scala:main Sep 27, 2022
@bishabosha
Copy link
Member

Thank you!

@benluo benluo deleted the _zh-cn/overviews/scala3-book/-add-html-lines branch September 28, 2022 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants