correct valueOrError to valueOrAbort #2539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
correct report.error to report.errorAndAbort
julienrf
reviewed
Sep 22, 2022
julienrf
reviewed
Oct 5, 2022
bishabosha
force-pushed
the
correct-macros.md
branch
from
0423507 to
85b5f31
Compare
julienrf
approved these changes
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some places the docs mention
valueOrErrorwhich is deprecated in favor ofvalueOrAbort.The missing
import quotes.reflect.*made it hard to figure out where thereportcomes from, I think it's worth including it if someone wants to follow along with the code in their IDE.