fix: needs var for Dog extends abstract class
#2453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the _Dog extends abstract class_ (aka Scala 2 way) `var` keyword is missing in the class defition ``` class Dog(name: String, age: Int) extends Pet(name): ... ``` As a result the `Dog` class fails to compile with the following error `class Dog needs to be abstract, since def age: Int in class Pet is not defined` adding `var` to the definition solves to problem ``` class Dog(name: String, var age: Int) extends Pet(name): ... ```
julienrf
approved these changes
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Dog extends abstract class (aka Scala 2 way)
varkeyword is missing in the class defitionAs a result the
Dogclass fails to compile with the following errorclass Dog needs to be abstract, since def age: Int in class Pet is not definedadding
varto the definition solves to problem