Skip to content

Improve getting-started experience for Java newcomers and OSS contributors #2414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 23, 2022
Merged

Improve getting-started experience for Java newcomers and OSS contributors #2414

merged 8 commits into from
Aug 23, 2022

Conversation

anatoliykmetyuk
Copy link
Contributor

No description provided.

bishabosha
bishabosha reviewed Jun 1, 2022
View reviewed changes
julienrf
julienrf requested changes Jun 1, 2022
View reviewed changes
Copy link
Contributor

@julienrf julienrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Anatolii!

In general, I think we should try to minimize the number of similar content. Here, I see that your contributions have a unique value, but they also overlap a bit with some existing content. I suggest that we try to incorporate your contributions to the existing content instead. Would that work for you?

@SethTisue SethTisue marked this pull request as draft August 3, 2022 00:43
@bishabosha bishabosha force-pushed the add-newcomers-articles branch from 0900b3c to 2dca1bf Compare August 12, 2022 14:57
@bishabosha bishabosha force-pushed the add-newcomers-articles branch 10 times, most recently from fc5af04 to 27c1189 Compare August 18, 2022 15:49
@bishabosha bishabosha force-pushed the add-newcomers-articles branch from 813cf12 to d24bf79 Compare August 22, 2022 09:34
@bishabosha bishabosha force-pushed the add-newcomers-articles branch from d24bf79 to 639ce43 Compare August 22, 2022 15:07
@bishabosha bishabosha marked this pull request as ready for review August 22, 2022 15:08
@bishabosha bishabosha changed the title Add newcomers articles Improve getting-started experience for Java newcomers and OSS contributors Aug 22, 2022
@bishabosha bishabosha requested a review from julienrf August 22, 2022 15:09
@bishabosha bishabosha removed their assignment Aug 22, 2022
@bishabosha
Copy link
Member

@julienrf This is now ready for second review

@bishabosha bishabosha force-pushed the add-newcomers-articles branch 2 times, most recently from ca396c3 to 3e00677 Compare August 22, 2022 15:31
julienrf
julienrf requested changes Aug 23, 2022
View reviewed changes
Copy link
Contributor

@julienrf julienrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much Jamie, this is a great improvement.

_overviews/tutorials/scala-for-java-programmers.md

## A First Example
When you finish these guides, we recommend to continue your Scala journey by reading the
*Scala Book* or following a number of *online MOOCs*.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should probably be links to the corresponding pages (Scala book and online courses)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are immediately followed by the relevant links - so I do not think it makes sense:

Screenshot 2022-08-23 at 16 05 07

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps it would not be confusing to link twice

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh ok sorry I didn’t see that!

@bishabosha bishabosha force-pushed the add-newcomers-articles branch from 3e00677 to a5d3cc5 Compare August 23, 2022 13:39
bishabosha and others added 5 commits August 23, 2022 15:40
@bishabosha @anatoliykmetyuk
move newcomer contribution to contribution guide
1d10e89 
Co-authored-by: Jamie Thompson <bishbashboshjt@gmail.com>
Co-authored-by: Anatolii Kmetiuk <anatoliykmetyuk@gmail.com>
@bishabosha
add Who can Contribute FAQ
aefdf65
@bishabosha
include old scala intro in page
8701b17
@bishabosha
integrate Java content in old tutorial
6a8c00f
@bishabosha
cleanups
520c8fe
@bishabosha bishabosha force-pushed the add-newcomers-articles branch from a5d3cc5 to 520c8fe Compare August 23, 2022 13:40
@bishabosha bishabosha requested a review from julienrf August 23, 2022 14:05
@bishabosha bishabosha merged commit e33b6c6 into main Aug 23, 2022
@julienrf julienrf deleted the add-newcomers-articles branch October 25, 2022 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bishabosha bishabosha bishabosha left review comments

@julienrf julienrf julienrf approved these changes

Assignees

@julienrf julienrf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anatoliykmetyuk @bishabosha @julienrf