Skip to content

Update optimizer overview #2336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 3, 2022
Merged

Conversation

som-snytt
Copy link
Contributor

Use the simplified options, but reference the old blog post.

Trim a few ambitious promises to explain more.

@som-snytt som-snytt requested a review from SethTisue February 24, 2022 05:46
@som-snytt
Copy link
Contributor Author

It would be useful to show a build.sbt snippet for "enable under CI".

Or, mention -opt:none and how to enable during dev workflow.

@som-snytt
Copy link
Contributor Author

This falls somewhere between "no fair!" and "that's life!"

Checking 1501 external links...
Ran on 1188 files!
- ./_site/overviews/scaladoc/contribute.html

  *  External link https://dotty.epfl.ch/docs/usage/dottydoc.html failed: 404 No error

- ./_site/scala3/reference/other-new-features/explicit-nulls.html
htmlproofer 3.15.3 | Error:  HTML-Proofer found 3 failures!
  *  External link https://dotty.epfl.ch/docs/internals/explicit-nulls.html failed: 404 No error
- ./_site/scala3/scaladoc.html
  *  External link https://dotty.epfl.ch/docs/usage/scaladoc/blog.html failed: 404 No error
Error: Process completed with exit code 1.

Copy link
Member

@SethTisue SethTisue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've requested a few trivial edits.

Maybe the compiler-options page could link to this new page?

@SethTisue
Copy link
Member

@lrytz I suggested to Som that after this is merged, I could take care of adding a notice to the top of your blog post directing people here instead.

Copy link
Member

@lrytz lrytz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you!

@som-snytt
Copy link
Contributor Author

I caved on Seth's points because I just read in the Sylvia Plath bio that Ted Hughes removed three poems from his book because Marianne Moore asked him to.

@SethTisue SethTisue merged commit 967f296 into scala:main Mar 3, 2022
@som-snytt som-snytt deleted the overview/optimizer branch March 3, 2022 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants