Skip to content

Add a missing translation in getting-started.md (Japanese) #2327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2022
Merged

Add a missing translation in getting-started.md (Japanese) #2327

merged 1 commit into from
Mar 11, 2022

Conversation

komainu8
Copy link
Contributor

@komainu8 komainu8 commented Feb 9, 2022

No description provided.

@SethTisue
Copy link
Member

review by @scala/docs-ja? (not sure why GitHub won't let me use the "request reviewers" feature to do this...)

eed3si9n
eed3si9n approved these changes Feb 10, 2022
View reviewed changes
Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eed3si9n
Copy link
Member

@SethTisue

(not sure why GitHub won't let me use the "request reviewers" feature to do this...)

I think docs-zh team has push rights on the repo, but other language teams do not?

@SethTisue SethTisue merged commit cd31908 into scala:main Mar 11, 2022
@SethTisue
Copy link
Member

thank you @komainu8 and @eed3si9n !

@komainu8 komainu8 deleted the add-missing-tranlation branch March 12, 2022 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eed3si9n eed3si9n eed3si9n approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@komainu8 @SethTisue @eed3si9n