Skip to content

Advertise some more compiler plugins #2011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 9, 2021
Merged

Advertise some more compiler plugins #2011

merged 5 commits into from
Jul 9, 2021

Conversation

kubukoz
Copy link
Contributor

@kubukoz kubukoz commented May 11, 2021

No description provided.

@@ -42,6 +42,7 @@ include:
- Alternate compiler back ends such as [Scala.js](https://www.scala-js.org), [Scala Native](http://scala-native.org), and
[Fortify SCA for Scala](https://developer.lightbend.com/docs/fortify/current/).
- Linters such as [Wartremover](https://www.wartremover.org) and [Scapegoat](https://github.com/sksamuel/scapegoat).
<!-- is this even accurate? scalafmt is not a _compiler_ plugin I think, and scalafix relies on the semanticdb plugin? -->
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would appreciate some help clarifying this. @tgodzik 🙏 :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Scalafix and scalafmt are not compiler plugins. Scalafmt is totally separate entity, while scalafix uses semanticdb.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing scalafmt is fine (I had thought it was semanticdb-based, oops!).

Removing scalahost is fine, too.

But it was never my intention to imply, through poor phrasing, that scalafix is a compiler plugin. I wanted to include it because it's so important and because its existence is enabled by semanticdb-scalac, which is a compiler plugin. Not everyone knows what semanticdb is, but everybody knows about scalafix.

Wdyt about the following replacement phrasing:

Plugins that enable tooling. One such plugin is semanticdb-scalac, which enables scalafix (a well-known refactoring and listing tool) to do its work.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Semanticdb is currently mentioned next to Paradise, but I guess I can rephrase it to mention scalafix explicitly ;)

kubukoz added 2 commits May 11, 2021 18:54
 scalafix/scalafmt aren't compiler plugins, scalahost isn't maintained.
@kubukoz
Copy link
Contributor Author

kubukoz commented May 11, 2021

OK, I think I'm good with these changes. @SethTisue can you approve me for workflows?

@kubukoz
Copy link
Contributor Author

kubukoz commented Jun 2, 2021

Took me some time... @SethTisue when you have a moment :)

@SethTisue SethTisue merged commit 738e262 into scala:main Jul 9, 2021
@SethTisue
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants