Conversion Between Option and Collection #1983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
why closed? (sometimes reviews are slow in this repo, sorry about that) |
julienrf
requested changes
Apr 27, 2021
There was a problem hiding this comment.
Thank you @mario-galic! I agree that it would be great to document better the relation between Option and the Scala collections, thank you so much for helping with that!
I’m not sure about some directions taken in the article, I’ve left some comments to explain my point of view. Please let me know what you think about it!
_overviews/collections-2.13/conversion-between-option-and-collection.md
Outdated
Show resolved
Hide resolved
_overviews/collections-2.13/conversion-between-option-and-collection.md
Outdated
Show resolved
Hide resolved
_overviews/collections-2.13/conversion-between-option-and-collection.md
Outdated
Show resolved
Hide resolved
_overviews/collections-2.13/conversion-between-option-and-collection.md
Outdated
Show resolved
Hide resolved
julienrf
reviewed
Apr 27, 2021
_overviews/collections-2.13/conversion-between-option-and-collection.md
Outdated
Show resolved
Hide resolved
_overviews/collections-2.13/conversion-between-option-and-collection.md
Outdated
Show resolved
Hide resolved
_overviews/collections-2.13/conversion-between-option-and-collection.md
Outdated
Show resolved
Hide resolved
_overviews/collections-2.13/conversion-between-option-and-collection.md
Outdated
Show resolved
Hide resolved
_overviews/collections-2.13/conversion-between-option-and-collection.md
Outdated
Show resolved
Hide resolved
julienrf
reviewed
Apr 27, 2021
_overviews/collections-2.13/conversion-between-option-and-collection.md
Outdated
Show resolved
Hide resolved
_overviews/collections-2.13/conversion-between-option-and-collection.md
Outdated
Show resolved
Hide resolved
_overviews/collections-2.13/conversion-between-option-and-collection.md
Outdated
Show resolved
Hide resolved
julienrf
approved these changes
Apr 27, 2021
|
Hello @mariogalic, would it be possible for you to clean the git history? Ideally, each contribution should be self-contained in a single commit. |
- Clarify if Option is considered a collection by summarising discussion at Make Option extend IterableOnce #8038 - Document implicit conversion option2iterable
|
Hi @julienrf, it should be done - I squashed all commits into single one and force pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optionis considered a collection by summarising discussion at Make Option extend IterableOnce #8038option2iterable