Update Scala 3 macro reflection #1895
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
update-scala3-macro-reflection
branch
from
99c63ad to
2385953
Compare
b-studios
reviewed
Jan 13, 2021
b-studios
reviewed
Jan 13, 2021
b-studios
reviewed
Jan 13, 2021
|
Are all links fixed? If yes, then maybe you can also remove the workaround in: https://github.com/scala/docs.scala-lang/blob/master/scripts/ci.sh#L19 - --url-ignore '/https://github.com/scala/docs.scala-lang/blob/master/.*/,/www.oracle.com/,/.*dotty.epfl.ch\/api\/scala\/tasty\/Reflection.*/'
+ --url-ignore '/https://github.com/scala/docs.scala-lang/blob/master/.*/,/www.oracle.com/'This way we detect breakage in the future |
nicolasstucki
force-pushed
the
update-scala3-macro-reflection
branch
from
1ecb660 to
1f5a8fd
Compare
|
Updted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes lampepfl/scala3-macro-tutorial#31 and fixes scala/scala3#10992