Skip to content

The first two sections were in the wrong order, so I reversed them #1679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

The first two sections were in the wrong order, so I reversed them #1679

wants to merge 1 commit into from

Conversation

alvinj
Copy link
Contributor

@alvinj alvinj commented Apr 9, 2020

I also simplified some other text.

@SethTisue
Copy link
Member

The CI failures show that you're working off an old version of the site, dating back to November 2019. Would you mind rebasing this against current master?

@alvinj
Copy link
Contributor Author

alvinj commented Apr 13, 2020

The CI failures show that you're working off an old version of the site, dating back to November 2019. Would you mind rebasing this against current master?

I’m sorry about that. I knew that “fork” went a lot faster than I expected it to, but I generally just use Git by myself on my own projects and didn’t know what to make of it. I’ll work on this on Monday.

@alvinj
Copy link
Contributor Author

alvinj commented Apr 13, 2020

I hope you don’t mind, I’m very short on time today, so I just forked a new copy of the docs and created a new pull request (#1682) off of it. I’ll be glad to learn about rebasing later this week, but I wanted to make sure I got this done today. (My apologies in advance if this causes more problems.)

@SethTisue
Copy link
Member

new PR is 100% fine!

@SethTisue SethTisue closed this Apr 13, 2020
@alvinj
Copy link
Contributor Author

alvinj commented Apr 13, 2020

That’s great — thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants