Skip to content

Improve the getting started page #1675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 19, 2020
Merged

Conversation

mlachkar
Copy link
Contributor

@mlachkar mlachkar commented Apr 1, 2020

  • making the page self contained: users can have a working "hello-world"
    without visiting other pages
  • introducing couriser-cli a recommended way to install jvm requirements
  • adding Vscode/metals as a possible IDE
  • advertising only two ways of starting with Scala: interactive with Scastie or with and IDE + sbt

image

@mlachkar mlachkar requested a review from Philippus April 5, 2020 22:39
You can [try Scala in your browser](https://scastie.scala-lang.org/MHc7C9iiTbGfeSAvg8CKAA), with access to all Scala compilers and
all published libraries.

## Installing Scala
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Installing Scala
## Install Scala

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And then, I would add a sentence explaining what that means to “install” Scala (ie, installing various command-line tools such as the Scala compiler and build tools), and that we are going to explain two ways of doing it: using the cs tool that automatically installs all the requirements, or by manually installing each thing.



Along with managing JVMs, it also installs useful command line tools:
ammonite, coursier, scala, scalac, sbt-launcher, scalafmt.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ammonite, coursier, scala, scalac, sbt-launcher, scalafmt.
[amm](https://ammonite.io/), [coursier](https://get-coursier.io/), scala, scalac (the Scala compiler), [sbt](https://www.scala-sbt.org/), [scalafmt](https://scalameta.org/scalafmt/).

BTW, @alexarchambault, is it useful to install the coursier CLI if we already have installed cs?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also discussed here: scala/scala-lang#1130 (comment)

After running cs setup for the first time, cs installs itself right? Should we recommend to delete the download?

We can, yes, and maybe should actually.

Copy link

@alexarchambault alexarchambault Apr 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, @alexarchambault, is it useful to install the coursier CLI if we already have installed cs?

It depends how you got cs. If you downloaded it manually, let it install cs itself in the installation directory, and remove the one you downloaded yourself.

More documentation about sbt can be found in the [Scala Book](/overviews/scala-book/scala-build-tool-sbt.html)
or in the official sbt [documentation](https://www.scala-sbt.org/1.x/docs/index.html)

### Without using the command line
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Without using the command line
### With an IDE

?

@mlachkar mlachkar requested a review from julienrf April 16, 2020 13:08
@mlachkar
Copy link
Contributor Author

@julienrf, @Philippus can you please review the new patch? Thanks

Copy link
Contributor

@julienrf julienrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mlachkar! I think the structure of the getting started page is greatly improved with your changes. I’m not sure about the english-style in some parts, though. @SethTisue, would you be interested in proof-reading?

@SethTisue
Copy link
Member

I apologize for neglecting this. How does this relate to scala/scala-lang#1162 ...?

If this PR is still considered active, lmk and I promise to review it for English style.

@martijnhoekstra
Copy link
Contributor

I didn't notice this was open! I'm closing scala/scala-lang#1162 for now, we can re-open if needed.

@mlachkar
Copy link
Contributor Author

mlachkar commented Oct 1, 2020

If we are going to be recommending the usage of coursier, the content of this PR is still accurate and I would love to have reviews again (@SethTisue).

Copy link
Member

@SethTisue SethTisue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a commit with some minor tweaks. (Feel free to accept or revert any of them.)

mlachkar and others added 9 commits October 19, 2020 16:54
* making the page self contained: users can have a working "hello-world"
without visiting other pages
* introducing couriser-cli a recommended way to install jvm requirements
* adding Vscode/metals as a possible IDE
* advertising only two ways of starting with Scala: interactive with Scastie or with and IDE + sbt
Co-Authored-By: Philippus Baalman <philippus@gmail.com>
Co-Authored-By: Philippus Baalman <philippus@gmail.com>
Co-Authored-By: Philippus Baalman <philippus@gmail.com>
Co-Authored-By: Philippus Baalman <philippus@gmail.com>
Co-Authored-By: Philippus Baalman <philippus@gmail.com>
Co-Authored-By: Philippus Baalman <philippus@gmail.com>
@mlachkar mlachkar force-pushed the getting-started-page branch from 0433764 to 9865a70 Compare October 19, 2020 14:56
@mlachkar mlachkar merged commit bcc5724 into scala:master Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants