Edit sentence for clarity #1518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this doesn't seem like an improvement to me. we want to say that the enforcement is taking place at compile-time. placing "at compile time" farther from the word "enforcement" obscures that rather than clarifies it, IMO. in the new version, it sounds like "at compile time" modifies "are used", which isn't the intended meaning. is there some other way of improving the wording to address the clarity problem you're seeing? |
Philippus
reviewed
Aug 30, 2019
Philippus
approved these changes
Sep 12, 2019
SethTisue
approved these changes
Sep 12, 2019
|
thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.