Skip to content

Rebase Korean translated tour introduction page #1479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 21, 2019
Merged

Conversation

eugene70
Copy link
Contributor

@eugene70 eugene70 commented Aug 4, 2019

Re-translate the "tour-of-scala.md" file because there were many changes
in the original text.

Re-translate the "tour-of-scala.md" file because there were many changes
in the original text.
@eed3si9n
Copy link
Member

eed3si9n commented Aug 5, 2019

@eugene70 Thanks for the contribution!

I can't review this myself so could you find someone who can? /cc @yoondo, @Naetmul, @byeonggukgong

@byeonggukgong
Copy link
Member

@eugene70 @eed3si9n I'll check it out this weekend :)

@byeonggukgong
Copy link
Member

LGTM

@SethTisue
Copy link
Member

needs rebase

Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eed3si9n eed3si9n merged commit 9c71a3b into scala:master Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants