-
Notifications
You must be signed in to change notification settings - Fork 1k
Use https instead of http #1471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@Philippus Thank you for your suggestion. |
@@ -54,7 +54,7 @@ sections: | |||
- title: "Language Spec" | |||
description: "Scala's formal language specification." | |||
icon: "fa fa-book" | |||
link: http://scala-lang.org/files/archive/spec/2.12/ | |||
link: https://scala-lang.org/files/archive/spec/2.13/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you apply same changes to _ja/index.md
too?
That file is Japanese translation of index.md
@exoego Yes. I applied the same change to the Japanese page too. |
@komainu8 Thanks !! |
Your commit message uses version 2.1.3, this should be 2.13. You may want to change it to have a nicer history. |
@Philippus Thank you for your comment. |
It seems that there is only one 404 in https://ci.scala-lang.org/scala/docs.scala-lang/374/3
|
@exoego Thank you for your comment. |
Co-Authored-By: Philippus Baalman <philippus@gmail.com>
I've finished modifying http to https(except not exist https site) in all document. |
this is much more broad than just fixing #1459; it changes all links, instead of only links within scala-lang.org that makes me a bit nervous. should I be nervous? if the link-checker likes it, then maybe it's okay...? |
Ah...I see. |
well, maybe it's fine as-is, actually. any other maintainers in this repo have an opinion? |
thank you @komainu8 !! |
Dear, developers.
I've fixed an issue #1459.