Skip to content

Use https instead of http #1471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 13, 2019
Merged

Use https instead of http #1471

merged 3 commits into from
Aug 13, 2019

Conversation

komainu8
Copy link
Contributor

Dear, developers.
I've fixed an issue #1459.

@komainu8
Copy link
Contributor Author

komainu8 commented Aug 1, 2019

@Philippus Thank you for your suggestion.
I've fixed it.

@@ -54,7 +54,7 @@ sections:
- title: "Language Spec"
description: "Scala's formal language specification."
icon: "fa fa-book"
link: http://scala-lang.org/files/archive/spec/2.12/
link: https://scala-lang.org/files/archive/spec/2.13/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you apply same changes to _ja/index.md too?
That file is Japanese translation of index.md

@komainu8
Copy link
Contributor Author

komainu8 commented Aug 1, 2019

@exoego Yes. I applied the same change to the Japanese page too.

@exoego
Copy link
Contributor

exoego commented Aug 1, 2019

@komainu8 Thanks !!

@exoego exoego mentioned this pull request Aug 1, 2019
@Philippus
Copy link
Member

Your commit message uses version 2.1.3, this should be 2.13. You may want to change it to have a nicer history.

@komainu8
Copy link
Contributor Author

komainu8 commented Aug 2, 2019

@Philippus Thank you for your comment.
I've fixed my commit message(version 2.1.3 -> version 2.13).

@exoego
Copy link
Contributor

exoego commented Aug 5, 2019

It seems that there is only one 404 in https://ci.scala-lang.org/scala/docs.scala-lang/374/3

  • ./_site/ja/overviews/parallel-collections/ctries.html

@komainu8
Copy link
Contributor Author

komainu8 commented Aug 5, 2019

@exoego Thank you for your comment.
I found also the other same broken links. So, I've also fixed them.

@komainu8
Copy link
Contributor Author

komainu8 commented Aug 6, 2019

I've finished modifying http to https(except not exist https site) in all document.

@SethTisue
Copy link
Member

this is much more broad than just fixing #1459; it changes all links, instead of only links within scala-lang.org

that makes me a bit nervous. should I be nervous? if the link-checker likes it, then maybe it's okay...?

@komainu8
Copy link
Contributor Author

komainu8 commented Aug 9, 2019

Ah...I see.
You're right. This PR is broad.
I reduce modify.

@SethTisue
Copy link
Member

I reduce modify.

well, maybe it's fine as-is, actually.

any other maintainers in this repo have an opinion?

@SethTisue SethTisue merged commit 75ef27e into scala:master Aug 13, 2019
@SethTisue
Copy link
Member

thank you @komainu8 !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants