Skip to content

Add Twitter card/OGProtocol for sharing pages on SNS #1468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2019

Conversation

exoego
Copy link
Contributor

@exoego exoego commented Jul 30, 2019

Add Twitter card & OG Protocol (for Facebook or other SNS) to docs.scala-lang.org.
Those are a rich preview of pages that may attract readers than ordinal text link, and easy to click on touch screen since bigger area.
Those are aledy included in scala-lang repo

image

@exoego exoego changed the title Add Twitter card/OGProtocol Add Twitter card/OGProtocol for sharing pages on SNS Jul 30, 2019
@jvican
Copy link
Member

jvican commented Jul 30, 2019

Thanks for this! @exoego LGTM! 😄

Copy link
Contributor

@julienrf julienrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great contribution! I have a few questions, though 👇

Copy link
Contributor

@julienrf julienrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Do you mind squashing your commits?

@exoego
Copy link
Contributor Author

exoego commented Jul 31, 2019

Squashed commits.

@SethTisue SethTisue merged commit 01a459c into scala:master Jul 31, 2019
@exoego exoego deleted the twitter-card branch July 31, 2019 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants